Skip to content

[TOOL-3044] Remove static generation of changelog pages #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[TOOL-3044] Remove static generation of changelog pages #5935

wants to merge 1 commit into from

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 13, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on updating the id prop in the Anchor and Heading components to allow for undefined values instead of just strings. Additionally, it removes the generateStaticParams function from the page.tsx file and adjusts the usage of the Heading component.

Detailed summary

  • Modified id prop in Anchor to accept string | undefined.
  • Modified id prop in Heading to accept string | undefined.
  • Updated Heading usage in transform.tsx to set id as undefined.
  • Removed generateStaticParams function from page.tsx.
  • Adjusted imports in page.tsx by removing fetchChangeLogs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 13, 2025

TOOL-3044 Remove static generation of changelog pages

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2774669

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ❌ Failed (Inspect) Jan 13, 2025 1:39pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Jan 13, 2025 1:39pm
thirdweb-www ⬜️ Skipped (Inspect) Jan 13, 2025 1:39pm
wallet-ui ⬜️ Skipped (Inspect) Jan 13, 2025 1:39pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 13, 2025 13:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 13, 2025 13:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 13, 2025 13:17 Inactive
@MananTank MananTank marked this pull request as ready for review January 13, 2025 13:17
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jan 13, 2025
@MananTank MananTank requested review from a team as code owners January 13, 2025 13:17
@MananTank Graphite App
Copy link
Member Author

MananTank commented Jan 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (332536b) to head (2774669).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5935   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files        1141     1141           
  Lines       60903    60903           
  Branches     5128     5128           
=======================================
  Hits        33396    33396           
  Misses      26781    26781           
  Partials      726      726
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 332536b
packages 52.47% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 549 ms (+45.49% 🔺) 1.5 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 848 ms (-8.36% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 88 ms (+253.17% 🔺) 200 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 135 ms (+470.67% 🔺) 145 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 275 ms (+209% 🔺) 660 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 13, 2025 13:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 13, 2025 13:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 13, 2025 13:34 Inactive
@MananTank MananTank closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MananTank MananTank

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MananTank